Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: conform qrix vac to plc repo standards and update version #20

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Jun 4, 2024

Description

Tidy up repo standards a bit to fix an archiving issue
closes #10 by addressing every issue in that ticket

Motivation and Context

Archive file wasn't being produced

How Has This Been Tested?

IOC still builds

Where Has This Been Documented?

Here only

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@ZLLentz ZLLentz requested review from ghalym and patoppermann June 4, 2024 20:37
Copy link

@patoppermann patoppermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@ZLLentz ZLLentz merged commit af8cf37 into pcdshub:master Jun 4, 2024
9 checks passed
@ZLLentz ZLLentz deleted the maint_repo_standards branch June 4, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repository maintenance tasks required
2 participants