Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap needle z limits #15

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Swap needle z limits #15

merged 3 commits into from
Sep 28, 2023

Conversation

jozamudi
Copy link
Contributor

Description

Swaped Limit switches for GasJetZ that controls gas-needle-Z.

Motivation and Context

Limit switches for gas_needle-z where swaped.

How Has This Been Tested?

Motor has been moved to confirm limit switches are correct.

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@jozamudi jozamudi requested a review from tongju12 September 28, 2023 22:39
tongju12
tongju12 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@tongju12 tongju12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tongju12 tongju12 merged commit cb288a9 into pcdshub:master Sep 28, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tongju12 tongju12 tongju12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jozamudi @tongju12