-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changing out el3602 for el3602-0002 and updating link #78
Conversation
This looks good to me. There's still an xti file for the old 3602 |
@c-tsoi did you run and push pre-commit on this? |
Yeah, I am pretty sure I did. Are edits that were corrected? |
I tried inputting some values from the el3602 manual into the IM4K2 custom analog input function block and I think there is a discrepency when plugging in max and min values. https://download.beckhoff.com/download/Document/io/ethercat-terminals/EL36xxen.pdf#page=150 iRaw for 10V should be 0x7FFFFFFF, or 2147483647. With iTermBits=32, fTermMax=10, fTermMin=-10 (not using fResolution and fOffset for simplicity) @ZLLentz @jozamudi, can you tell me if this makes sense since you worked on #68 that added the custom analog input block for im4k2? One of the sanity checks in #68 (comment) used 2^32-1 as the iRaw for a max voltage of 10V, but this seems to disagree with the manual page I was looking at. |
I think you're right. It looks like the iTermBits should be changed. |
I think you're right too. I've gotten this one wrong too many times! Which means, maybe there's a better way to parameterize these that is less prone to errors.... |
Is there a way to make FB_AnalogInput.TcPOU capable of handling DINTs and INTs? For example, can we make |
@c-tsoi once you make my suggestion can you makr this as ready for review and then we can merge? |
plc-kfe-rix-motion/kfe_rix_motion/POUs/IM4K2/FB_PPM_PowerMeter_IM4K2.TcPOU
Outdated
Show resolved
Hide resolved
…_IM4K2.TcPOU Co-authored-by: KaushikMalapati <[email protected]>
Description
We added the new EL3602-0002 and swapped it for the EL 3602.
Motivation and Context
The old slice was reading out incorrectly and a scientist requested us to change it out.
How Has This Been Tested?
Kaushik and I changed out the slice, logged into the plc and saw that the terminal was reading back a reason value.
Kaushik and Philip will do a checkout on Thursday to verify that it is working as requested.
Where Has This Been Documented?
Screenshots (if appropriate):
Pre-merge checklist
Always Newest
pre-commit
(alternativelypre-commit run --all-files
)