Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tm1k2 target 7 and 8 #77

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Conversation

patoppermann
Copy link
Contributor

@patoppermann patoppermann commented Dec 3, 2024

Description

Do not merge! Just feedback!
Add tm1k2 target positions and change the values.
https://jira.slac.stanford.edu/browse/ECS-6928

Target 1a: -28 ITO (green)
Target 1b: -38 GaAs
Target 2a: -48 Si
Target 2b: -58 Ge
Target 3a: -68 ITO (purple)
Target 3b: -80 YAG
Target 4: -96 frosty YAG
Target 5: -114.5 diode

Motivation and Context

Message from giacomo:
Please update the qRIXS presets to the following numbers and names. Please note that the number of targets has changed

How Has This Been Tested?

Not testing!!
Add the moment just for feedback.

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@patoppermann patoppermann requested a review from jyotiphy December 3, 2024 18:45
Copy link
Contributor

@jyotiphy jyotiphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@patoppermann patoppermann merged commit 59e92f4 into pcdshub:master Dec 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants