-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding veto for link fault and changing max_faults to 200 #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a strictly positive change
A few more things to note:
- I think the i_xOK veto update actually isn't needed, and only was needed because of the FF count. I think the FFO forces a not OK state when it has too many FFs and ignores its own veto, which is why this FF got tripped. But redundancy is OK and maybe even good here.
- We ended up only needing 104 slots. Next week we should do a follow-up PR where we cut down on the number of slots and/or limit the number exposed to EPICS to speed up the boot time. Possibly the most sane is to keep it at 200 but limit the arrays to ~30 and ~115 in EPICS respectively.
- We would have caught this ahead of beam time if we had implemented Better diagnostics for full FFO allocations pmps-ui#90. I've made this a jira ticket as well now at https://jira.slac.stanford.edu/browse/ECS-3964
@@ -43,7 +43,7 @@ epicsEnvSet("ASYN_PORT", "ASYN_PLC") | |||
epicsEnvSet("IPADDR", "172.21.140.70") | |||
epicsEnvSet("AMSID", "172.21.140.70.1.1") | |||
epicsEnvSet("AMS_PORT", "851") | |||
epicsEnvSet("ADS_MAX_PARAMS", "23542") | |||
epicsEnvSet("ADS_MAX_PARAMS", "16838") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty healthy PV count drop (23542 -> 16838) 👍
If we cut down the pmps too we might get a pretty fast boot time
Description
Adding veto for link fault and changing max_faults to 200
Motivation and Context
During beamtime, it was found that link faults aren't vetoed by stopper
And MAX_faults was 100
How Has This Been Tested?
not yet
Where Has This Been Documented?
no
Screenshots (if appropriate):
Pre-merge checklist
Always Newest
pre-commit
(alternativelypre-commit run --all-files
)