Veto IM1K3 when MR1K3 is OUT #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghalym
reviewed
Nov 23, 2024
| @@ -23,6 +23,10 @@ VAR | |||
| bMoveOk := TRUE, | |||
| bValid := TRUE | |||
| ); | |||
|
|
|||
| fbFakeFastFaultOutput: FB_HardwareFFOutput := (i_xVeto:=True); | |||
There was a problem hiding this comment.
we shouldn't use a fake arbiter.
we should use veto arbiter with the correct veto.
https://confluence.slac.stanford.edu/display/L2SI/PMPS+Veto+Tutorial
KaushikMalapati
changed the title
KaushikMalapati
changed the title
|
@ghalym could you please re-review this? I tried adding a veto arbiter and virtual fast fault like in the page you linked. |
KaushikMalapati
force-pushed
the
IM1K3-VETO
branch
from
18ba7d0 to
9367f89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
https://jira.slac.stanford.edu/browse/ECS-6866
How Has This Been Tested?
Where Has This Been Documented?
Screenshots (if appropriate):
Pre-merge checklist
Always Newestpre-commit(alternativelypre-commit run --all-files)