Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/BLD: update libraries to get cc temp ffos, fix some warnings #123

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Aug 20, 2024

Description

Apply common component temperature fast faults to the following shared devices on the kfe line:

  • AT1K4
  • IM1K3 (required some IO link name changes ThermoCouple -> TempSensor)

AT1K4 needed to be added to the database, I gave it an absurd default temp of 999 to avoid interrupting ops. I'll bring this up at the next PMPS meeting.

IM1K3 already had a temperature assigned to it in the PMPS database.

The other devices on this PLC largely don't have any temperature sensing devices, so there aren't any other faults to include.

It is possible to deploy this for the power slits too, but that hasn't been asked for yet, nor has it been prepared in the pmps database. To do this, we need to remove the FB_Slits etc. from this repo in favor of the one from the common components library, and update the call arguments to find the right database entry.

In the process of the above, update the following library versions to latest:

  • lcls-twincat-motion 4.0.4 -> 4.1.1
  • lcls-twincat-common-components 3.3.0 -> 3.5.0
  • lcls-twincat-pmps 3.0.14 -> 3.3.0

Also, the following build warnings were fixed in a few places:

  • DUT -> ST renames to remove deprecation warning (same behavior)
  • Remove trailing ; in tcLinkTo

This also updates the IOC version and pushes the new db files for PV regression tracking.

Motivation and Context

Follow-ups to https://jira.slac.stanford.edu/browse/ECS-4472

How Has This Been Tested?

This must be tested before it is merged:

  • Stuff still moves
  • Insert devices, make sure no faults
  • Fake the temperature inputs, make sure yes faults

Where Has This Been Documented?

Here only

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@ZLLentz ZLLentz requested review from ghalym and joshc-slac August 20, 2024 00:42
@ZLLentz
Copy link
Member Author

ZLLentz commented Aug 20, 2024

It seems like the attenuator doesn't have a database entry. I need to double-check what the code change was for these and what sort of database setup is expected.

@ZLLentz
Copy link
Member Author

ZLLentz commented Aug 20, 2024

Should be ready to test now

@ZLLentz
Copy link
Member Author

ZLLentz commented Aug 20, 2024

In retrospect, this isn't so crucial to get in quickly because the only useful device this might protect is AT1K4. So, if it needs to wait for any reason at all I don't mind. I have not activated config yet.

Copy link
Contributor

@ghalym ghalym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ZLLentz
Copy link
Member Author

ZLLentz commented Aug 30, 2024

This is on hold until we test it on the wed sept 4th pomm
It's fairly simple and we can re-apply it on top of other work done in the interim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants