Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EBD/FEE Flow Switch Readbacks #120

Merged
merged 14 commits into from
Dec 8, 2023
Merged

EBD/FEE Flow Switch Readbacks #120

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
82fdcfe
ENH: add flowswitch links for PC1K0, IM1K0, SL1K0
nrwslac Oct 31, 2023
35745db
ENH: add flowswitch readbacks for IM2K0, SL2K0, PF1K0
nrwslac Oct 31, 2023
77b9737
ENH: implement flow switch for IM1K4, PC1K4
nrwslac Oct 31, 2023
d9a361e
ENH: make photon collimator fbFlowSwitch calls
nrwslac Oct 31, 2023
f4c6bcc
ENH: PC flowswitch declared as VAR, VAR_OUT in function block
nrwslac Oct 31, 2023
cd3e8bf
DOC: run pre-commit
nrwslac Oct 31, 2023
1567e73
ENH: implement ST1K4 flowswitch
nrwslac Oct 31, 2023
a1d9396
ENH: IM1K3 flow switch implem
nrwslac Oct 31, 2023
2143b30
BUG: update IM1K3 pragma
nrwslac Nov 1, 2023
59c6af9
ENH: make IO name conform
nrwslac Nov 1, 2023
25feda7
ENH: make IO name conform
nrwslac Nov 1, 2023
0751d41
ENH: update common components lib to 3.3.0
nrwslac Nov 1, 2023
47cefce
DOC: fix terminal namining E5A had one link, 9505-E5 had no links
nrwslac Nov 2, 2023
4eb9879
BUG: debug flow switch variable linking - all checked good
nrwslac Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../IO/Device 1 (EtherCAT)/Power (EK1200)/PLC Junction 1 (EK1122)/X2 IM1K0-XTES (EK1100).xti
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<Box File="IM1K0-EL6021.xti" Id="33">
<EtherCAT PortABoxInfo="#x01000020"/>
</Box>
<Box File="EBD-PCW-FSW-EL1004.xti" Id="168">
<Box File="IM1K0-EL1004.xti" Id="168">
<EtherCAT PortABoxInfo="#x01000021"/>
</Box>
<Box File="IM1K0-EL6002.xti" Id="34">
Expand Down
0 ...M1K0-XTES (EK1100)/EBD-PCW-FSW-EL1004.xti → ...)/X2 IM1K0-XTES (EK1100)/IM1K0-EL1004.xti
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions ...ion 3 (EK1122)/X1 TMO FEE EC1 (EK1100)/TMO FEE EC1 E1 (EK1122)/X2-ST1K4-TEST (EK1100).xti
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@
<Box File="ST1K4-EL7041-E4.xti" Id="116">
<EtherCAT PortABoxInfo="#x01000073"/>
</Box>
<Box File="FEE-K-PCW-FSW-EL1004.xti" Id="240">
<Box File="ST1K4-EL1004-E5.xti" Id="240">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that there's already an E5 in the IO tree here. Is this a typo, or was ST1K4-EL9505-E5 always named wrong (should it be E6?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think whats going on here is E5 at install exists turning the following terminals into 5V. Next someone adds an EL5042 calls it E5A before the 9505, next someone adds EL1004 Before E5A calls it correctly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's currently an 1004-E5, 5042-E5A, followed by 9505-E5

Copy link
Member

@ZLLentz ZLLentz Nov 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, that explains the confusion here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could quickly fix this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would ask you to, but this also needs to involve updating drawings, terminal labels, and maybe even captars, so it might not necessarily be worth your time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is incidentally a device that never had a drawing until I started hooking stuff up to it, so its probably not a big deal to update. Its actually been stuck in purgatory for awhile:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://trello.com/c/HvURG1e1/256-05ops-fee-sc-fsw-st1-im1k4-r-1-e4
not a bad idea to get it pulled from the darkness into a JIRA ticket

<EtherCAT PortABoxInfo="#x01000074"/>
</Box>
<Box File="ST1K4-EL5042-E5A.xti" Id="241">
<Box File="ST1K4-EL5042-E6.xti" Id="241">
<EtherCAT PortABoxInfo="#x010000f0"/>
</Box>
<Box File="ST1K4-EL9505-E5.xti" Id="117">
<Box File="ST1K4-EL9505-E7.xti" Id="117">
<EtherCAT PortABoxInfo="#x010000f1"/>
</Box>
<Box File="ST1K4-EL9011.xti" Id="118">
Expand Down
0 ...K4-TEST (EK1100)/FEE-K-PCW-FSW-EL1004.xti → ...2-ST1K4-TEST (EK1100)/ST1K4-EL1004-E5.xti
View file
Open in desktop
File renamed without changes.
0 ...-ST1K4-TEST (EK1100)/ST1K4-EL5042-E5A.xti → ...2-ST1K4-TEST (EK1100)/ST1K4-EL5042-E6.xti
View file
Open in desktop
File renamed without changes.
0 ...2-ST1K4-TEST (EK1100)/ST1K4-EL9505-E5.xti → ...2-ST1K4-TEST (EK1100)/ST1K4-EL9505-E7.xti
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion plc-kfe-motion/_Config/NC/Axes/ST1K4-TEST.xti
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1530,7 +1530,7 @@ External Setpoint Generation:
</Axis>
<Mappings>
<OwnerA>
<OwnerB Name="TIID^Device 1 (EtherCAT)^Power (EK1200)^PLC Junction 3 (EK1122)^X1 TMO FEE EC1 (EK1100)^TMO FEE EC1 E1 (EK1122)^X2-ST1K4-TEST (EK1100)^ST1K4-EL5042-E5A">
<OwnerB Name="TIID^Device 1 (EtherCAT)^Power (EK1200)^PLC Junction 3 (EK1122)^X1 TMO FEE EC1 (EK1100)^TMO FEE EC1 E1 (EK1122)^X2-ST1K4-TEST (EK1100)^ST1K4-EL5042-E6">
<Link VarA="Enc^Inputs^In^nComState" VarB="WcState^InputToggle" Size="1" OffsA="1"/>
<Link VarA="Enc^Inputs^In^nComState" VarB="WcState^WcState"/>
<Link VarA="Enc^Inputs^In^nDataIn1" VarB="FB Inputs Channel 1^Position"/>
Expand Down
Loading