Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Comments Explaining RCI AI/AO #7

Open
ZLLentz opened this issue Jul 19, 2021 · 1 comment
Open

Add Comments Explaining RCI AI/AO #7

ZLLentz opened this issue Jul 19, 2021 · 1 comment

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Jul 19, 2021

Our twincat general library has function blocks for handling analog input and output: https://github.com/pcdshub/lcls-twincat-general/blob/master/LCLSGeneral/LCLSGeneral/POUs/Hardware/FB_AnalogInput.TcPOU

But these were not used in #6.
We should add some comments/documention as to why they needed to be modified, and/or we should add an issue to the general lib to fix these FBs.

@slactjohnson
Copy link
Collaborator

I have opened up an issue at pcdshub/lcls-twincat-general#54. The tl;dr is that these failed for negative values and I had to make some quick changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants