-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding epicsArchVerify to epicsArchChecker #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now and I'll refer to @tangkong et al for a more technical review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the JIra ticket, I thought the intended behavior was:
if LCLS2_HUTCH:
run epicsArchVerify
elif LCLS1_HUTCH:
run epicsArchChecker
It seems that this runs both for LCLS2Hutches. The above is what Chris O'Grady suggested in the ticket. Have we confirmed that we don't miss anything by running just epicsArchVerify
?
@tangkong thank you for the quick check: Kaushik did check if epicsArchVerify finds everything that epicsArchChecker does and it does not, so we can't easily do as originally suggested. For now, we are going with 'this is better' and will deal with the duplication of checks in a future release, mainly as we'd need to decide where the full check is supposed to live (engineering_tools or the DAQ release) and opinions on the correct solution may differ. |
Description
Adding a switch to run epicsArchVerify in epicsArchChecker, and running it by default for lcls2 hutches.
Motivation and Context
https://jira.slac.stanford.edu/browse/ECS-6632
How Has This Been Tested?
Interactively
Where Has This Been Documented?
Updated readme and file comments