MNT/STY/TST: Add pre-commit hooks, CI job, standardize style #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangkong
force-pushed
the
mnt_pre_commit
branch
2 times, most recently
from
74ad6c5 to
ee2644a
Compare
tangkong
force-pushed
the
mnt_pre_commit
branch
from
5ad640b to
548dcea
Compare
tangkong
changed the title
ZLLentz
reviewed
Apr 25, 2024
| if not foundHutch and path.find('xrt')+hostname.find('xrt')>=-1 or path.find('xtod')+hostname.find('xtod')>=-1: | ||
| hutch='LFE' #because we have so many names for the same subnet. | ||
| foundHutch=True | ||
| if (not foundHutch and path.find('xrt')+hostname.find('xrt') >= -1 |
There was a problem hiding this comment.
I'm slightly surprised this line passes flake8 with the lack of + spacing
There was a problem hiding this comment.
I'm also confused about this...
ZLLentz
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
- [ ] bash scripts (hooooo boy)Motivation and Context
The style is whack.
Shellcheck is a much larger effort, and one that we should be careful with. We'll have to go through those more carefully, but for now the CI will only check diff'd files
I spent way too much time trying to grab specific sha's for pre-commit's
--from-refand--to-refarguments, but the location of that information in thegithubpayload was inconsistent between push and pull-request. At that point I figured I should just get it working.How Has This Been Tested?
Pre-commit vomits all over my terminal repeatedly
Where Has This Been Documented?
This PR