TST: clean up pytest spam, warnings #70
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
shutdown
method toActionNode
to clean up the worker on shutdown.py_trees
describes this as something like "the opposite ofsetup
" so since we set the worker up insetup
, this seems like the canonical place to clean up the worker.ActionNode
's logic so it only cleans up the worker once.Motivation and Context
atexit
hook is correct and necessary, but causes issues (spam) inpytest
due to some sort of cleanup ordering that I wasn't able to pin down.flaky
mark is used incaproto
and comes frompytest-rerunfailures
. Since we don't want to use flaky tests, instead I opted to register the mark so pytest would stop complaining about it existing.How Has This Been Tested?
Unit tests still work
Unit tests no longer spam on exit
Where Has This Been Documented?
Release notes
Pre-merge checklist
docs/pre-release-notes.sh
and created a pre-release documentation page