Skip to content

Commit

Permalink
Merge PR 9.
Browse files Browse the repository at this point in the history
Update devDependencies.
Resolved a few eslint warnings.
tsc no longer removes comments in generated code.
  • Loading branch information
pcafstockf committed Jul 14, 2021
1 parent 4ffb6c0 commit df0b9c4
Show file tree
Hide file tree
Showing 10 changed files with 672 additions and 5,234 deletions.
42 changes: 24 additions & 18 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Fix issue #1
Update ts-node and source-map-support devDependencies
Add tslint and Changelog
Update ReadMe with badges
Update ReadMe with badges

**1.0.8 / 2020-06-08**
Add ability to walk up the parent container hierarchy to methods Injector.isIdKnown and Container.removeBinding
Expand All @@ -15,28 +15,34 @@ Updated tslib
Updated jasmine devDependency.

**1.2.0 / 2021-06-08**
New Feature: Allow alternate polyfill for Reflect API
WARNING: This is a a breaking change release.
The API and code have not changed, but you will need to explicitly import a polyfill into your own code in order to use this release (see the ReadMe).
Previously Async-Injection relied on reflect-metadata (which is still supported), but this release also allows for the use of alternative implementations such as:
New Feature: Allow alternate polyfill for Reflect API
WARNING: This is a a breaking change release.
The API and code have not changed, but you will need to explicitly import a polyfill into your own code in order to use this release (see the ReadMe).
Previously Async-Injection relied on reflect-metadata (which is still supported), but this release also allows for the use of alternative implementations such as:
core-js (core-js/es7/reflect)
reflection
Thank you to @tripodsgames for this contribution.
Thank you to @tripodsgames for this contribution.

**1.2.3 / 2021-06-11**
cjs and esm distributions
Build now generates both cjs and esm distributions.
tslib (where used) is now inlined instead of imported.
No other code changes.
cjs and esm distributions.
Build now generates both cjs and esm distributions.
tslib (where used) is now inlined instead of imported.
No other code changes.

**1.2.4 / 2021-06-17**
Build esm into esm dir (not mjs).
No actual source code changes.
Build esm into esm dir (not mjs).
No actual source code changes.

**1.2.5 / 2021-06-28**
No actual source code changes.
Added Reflect type from reflect-metadata in order to remove the @ts-ignore comments.
Improved tsconfig.json structure for IDE compatibility.
Thanks to @tripodsgames for those contributions.
Update tsc devDependency from 4.3.3 to 4.3.4.
Update the ChangeLog to properly reflect recent GitHub releases.
No actual source code changes.
Added Reflect type from reflect-metadata in order to remove the @ts-ignore comments.
Improved tsconfig.json structure for IDE compatibility.
Thanks to @tripodsgames for those contributions.
Update tsc devDependency from 4.3.3 to 4.3.4.
Update the ChangeLog to properly reflect recent GitHub releases.

**1.2.6 / 2021-07-14**
Merge PR [https://github.com/pcafstockf/async-injection/pull/9](ESLINT integration + Improvements).
Update devDependencies.
Resolved a couple of eslint warnings.
tsc no longer removes comments in generated code. This can cause problems with post-processing tools such as istanbul. If file size is of concern to you, you should probably be minifying anyway.
7 changes: 6 additions & 1 deletion ToDo.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
Someday / Maybes
- [ ] Find and implement a more maintainable api doc strategy (currently run this command and hand edit a lot: typedoc --excludeExternals --excludeNotExported --excludePrivate --includeVersion --toc Injector,Binder,Container,Injectable,Inject,Optional,PostConstruct --mode file --out tmp-docs src)
- [ ] Update the gh-pages branch (it's pretty out of date).
- [ ] Integrate nyc coverage report into GitHub Actions (https://github.com/codecov/codecov-action), and add a badge for it.
- [ ] Figure out why nyc chokes on sourceMaps. (seems to work for us first time but not after there is an .nyc_output dir): https://github.com/istanbuljs/nyc/issues/847#issuecomment-397439475 For now, just nuke before run.
- [ ] ESLINT integration.
- [X] ESLINT integration.
- [ ] Add tests that mis-appy decorators (see src/decorators.ts)
- [ ] Add tests for removing container bindings
- [ ] Add tests for checking if a binding is known by traversing up the Container hierarchy.
- [ ] Is there a real world scenario where we would attempt Container.resolve on a rejected synchronous singleton binding? I'm thinking maybe a synchronous object that threw on construction, and was subsequently a parameter in an asynchronous constructor of a depending singleton object? If so add a unit test, otherwise remove the code that handles this (see coverage of provider.ts, container.ts).
Loading

0 comments on commit df0b9c4

Please sign in to comment.