Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test output env invariant #40

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Conversation

IBims1NicerTobi
Copy link
Collaborator

No description provided.

@VonTum VonTum marked this pull request as ready for review December 5, 2024 15:45
@VonTum VonTum marked this pull request as draft December 6, 2024 13:45
@VonTum VonTum marked this pull request as ready for review December 9, 2024 17:09
@@ -20,7 +20,13 @@ impl Cache<FileUUID> for (&Linker, &mut ArenaVector<Source<String>, FileUUIDMark
Ok(&self.1[*id])
}
fn display<'a>(&self, id: &'a FileUUID) -> Option<Box<dyn std::fmt::Display + 'a>> {
Some(Box::new(self.0.files[*id].file_identifier.clone()))
if config().ci {
let filename = self.0.files[*id].file_identifier.rsplit("/").next().unwrap_or(self.0.files[*id].file_identifier.as_str());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused for a sec, thinking PathBuf should have methods for extracting the filename. But indeed, file_identifier is a String because it's only used to have a human-readable ID, and not used to do actual File IO.

Copy link
Collaborator

@VonTum VonTum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, I would change nothing.

@VonTum VonTum linked an issue Dec 9, 2024 that may be closed by this pull request
2 tasks
@VonTum VonTum merged commit a806ce1 into master Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make test.sus_regression.sh's output environment-invariant
2 participants