-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature improved collections #50
Open
mystardious
wants to merge
9
commits into
pbrink231:master
Choose a base branch
from
mystardious:feature_improved_collections
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature improved collections #50
mystardious
wants to merge
9
commits into
pbrink231:master
from
mystardious:feature_improved_collections
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should run some tests on other Plex scanners and agents such as TheTVDB agent.
Made my own changes as well as completed other todos, I have only tested the first case FilmType.SHOW however mixing shows and episodes is not possible so don't have mixed lists with show, season or episode items
Plex Smart Collections cannot have a custom order and is limited for sorting options since you cannot have the order of your choice set. Making use of non-smart collections avoids this issue and allows for unlimited number of custom ordered lists. When the script is run again the collection is not deleted therefore allowing for it to be pinned on users home screen and allows for it to be updated by changes in your list.
- Users are able to sort collections by alphabetical, release date, or imported list order using the sort option in list ("sort":"alpha/release/custom") - Updated settings.ini.example to include sort options - Added extra argument in film_list for sort parameter
- This method is not available in the plexapi module which is why I had to implement from scratch - For now all collections will be promoted by default. - When updating collection visibility moving items in the collection may undo collection visibility updates, therefore try to update visibility after making edits to a collection.
- Regular class gives a bit more functionality
- You can now update collection visibility, promotedToRecommended, promotedToOwnHome, promotedToSharedHome - Add methods to make requests to plex (PUT, GET, POST) in plex_request.py - Added method to manipulate collection order (Not in use yet), order is currently based on order in list provided in settings. - Refactored collection manipulation code in collection.py - Updated setting.ini.example comments for visibility as well as add example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collections:
Other:
Feedback on my code would be appreciated, thanks.