pam-test: set PAM_RUSER when running an auth test and allow skipping stack config checks #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PAM_RUSER is important in contexts where a local user is escalating to a higher-privilege local user (e.g. su, sudo). Modules like pam_ssh_agent_auth rely on it to drop their privileges to those of the requesting user when accessing files.
|
Let me use this space to say, thanks a lot for pam-test! It's made my life much easier today! |
There are scenarios under which it makes sense not to check the config: * A system may locate its pam config in a non-standard place; * One may want to test what happens if the caller application has no config (e.g. to test /etc/pam.d/other); * One may be running under `https://cwrap.org/pam_wrapper.html` and using an alternative configuration in the context of a test. But this check is useful in 90% of cases, so it's worth keeping enabled by default.
korfuri
changed the title
getlogin(3) returns the username of the user owning the controlling terminal of the process. When running pam-test in a CI environment, it's quite possible for the program to run without a controlling terminal at all, which returns NULL, which segfaults pam-test. Instead, cuserid(3) returns the username of the geteuid(2) user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAM_RUSER is important in contexts where a local user is escalating to a higher-privilege local user (e.g. su, sudo). Modules like pam_ssh_agent_auth rely on it to drop their privileges to those of the requesting user when accessing files.
Also, I'm testing my auth module under pam_wrapper (https://cwrap.org/pam_wrapper.html) and this allows using an alternative config. This PR includes another commit to allow optionally skipping the stack config checks.
Happy to unbundle these 2 changes if you'd rather I do that.