PR-4469: support drop in config schema #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraksi
reviewed
Jan 24, 2024
| throw NSError(domain: "ConfigError", code: 0, userInfo: [NSLocalizedDescriptionKey: "Missing Config"]) | ||
| } | ||
|
|
||
| if let tokenization = cseConfig.tokenization { |
There was a problem hiding this comment.
I like this part where the logic is independent of the provider type. One question though - will there ever be a case where we have both?
There was a problem hiding this comment.
@kumaraksi Could be, but in that case shouldn't the publicKey be the same?
kumaraksi
approved these changes
Jan 24, 2024
in2lag
approved these changes
Jan 30, 2024
grgmgd
added a commit
that referenced
this pull request
Jan 31, 2024
* feat: exposed encrypt card function * refactor: renaming encryptCard to encryptCardData * PR-4469: support drop in config schema (#9) * feat: support for dropIn initialization config * fix: relax vaultConfiguration required fields * feat: version bump to 0.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds the following: