Add support for 'payment-flow' query param for the web-sdk bridge #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bywood
approved these changes
Oct 18, 2024
wsbrunson
approved these changes
Oct 18, 2024
dtjones404
reviewed
Oct 18, 2024
| @@ -91,17 +91,31 @@ function validateWebSDKUrl({ pathname, query }) { | |||
| ); | |||
| } | |||
| // check for extraneous parameters | |||
| Object.keys(query).forEach((param) => { | |||
| if (param !== "version" && param !== "origin") { | |||
| const validWebSDKBridgeParams = ["origin", "version", "payment-flow"]; | |||
There was a problem hiding this comment.
should we add 'debug' here?
There was a problem hiding this comment.
Good point @dtjones404! I'll send a follow up PR for adding support for the optional debug param.
There was a problem hiding this comment.
@dtjones404 here's the follow up PR to add support for the debug query param: #219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new
payment-flowquery parameter for the web-sdk bridge url.