Skip to content
This repository has been archived by the owner on Jul 20, 2020. It is now read-only.

added html and unicode email support to advanced example #118

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

BigRedBot
Copy link
Contributor

@BigRedBot BigRedBot commented Jan 6, 2018

Added a send_email function to simplify sending html emails with added unicode support.

@randstraw randstraw self-requested a review January 9, 2018 21:50
Copy link
Contributor

@overint overint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have examples this complex in the repo, which are for a pretty specific use case. We should be providing something that others can extend, but I think this is of little use to most people as most frameworks provide a lot of this functionality already.

In addition, the code in this PR (and the file being edited) is not compliant with modern PHP standards.

I'd be interested in your thoughts on this kind of example @pp-randy

@BigRedBot
Copy link
Contributor Author

I mostly wanted to add an example of unicode support for the email. Honestly, I am not sure what parts are not compliant with modern PHP standards. I would be interested to know.

I removed the option for raw data logging. Other than a few functions for email that have been added for unicode and html support, this isn't any more complex than what is already in this file.

Other than making the case to remove this file entirely, I see no reason not to add these changes, to at least correct its lack of unicode support when sending emails.

@@ -4,12 +4,14 @@
$enable_sandbox = true;

// Use this to specify all of the email addresses that you have attached to paypal:
$my_email_addresses = array("my_email_address@gmail.com", "my_email_address2@gmail.com", "my_email_address3@gmail.com");
$my_email_addresses = array("seller@paypalsandbox.com", "seller2@paypalsandbox.com", "seller3@paypalsandbox.com");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can emails be @example.com ?

Copy link
Contributor Author

@BigRedBot BigRedBot Jan 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so.
I have changed it to use: example.com

@BigRedBot BigRedBot changed the title added html and unicode email support added html and unicode email support to advanced example Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants