Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#151] Improve users.html page by adding percentage of old files #155

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

pjeli
Copy link
Collaborator

@pjeli pjeli commented Oct 31, 2018

Make sure you have checked all steps below.

GitHub Issue

Fixes #151

Checklist:

  • This pull request updates the documentation
  • This pull request changes the code
  • Title of the PR is of format (example) : [#25] Add Pull Request Template, where [#25] is the GitHub issue number

What is the purpose of this pull request?

How was this change validated?

Commit Guidelines

  • My commits all reference GH issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@pjeli pjeli self-assigned this Oct 31, 2018
@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@07e2769). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #155   +/-   ##
=========================================
  Coverage          ?   76.88%           
  Complexity        ?     1069           
=========================================
  Files             ?       40           
  Lines             ?     5585           
  Branches          ?      516           
=========================================
  Hits              ?     4294           
  Misses            ?      976           
  Partials          ?      315

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e2769...e74d051. Read the comment docs.

@pjeli pjeli merged commit 2a3e68c into paypal:master Nov 1, 2018
@pjeli pjeli deleted the issue-151 branch November 1, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant