feat(ui): toggle showing only modified fields in version diff view #10807

tsemachh · 2025-01-26T08:16:53Z

Description

As an author reviewing the versions I have for a document , I would like to the ability to focus only on the differences I made and not see the entire document.
Screencast from 2024-09-05 16-38-40.webm

A checkbox was added to the Version View allowing user to decide if he/she wants to see only modified fields or the entire documents.
#7981 - mention this feature and also in discord

[v] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

[v] New feature (non-breaking change which adds functionality)

Checklist:

[ ] Existing test suite passes locally with my changes
(Actually it's stuck on S3 upload test , note related to my code)

One lat question - should we really translate text for all locales ? or we can leave it undefined for now ?(besides english)

…only-version-diff-view # Conflicts: # packages/next/src/views/Version/Default/index.tsx # packages/next/src/views/Version/RenderFieldsToDiff/fields/Iterable/index.tsx # packages/next/src/views/Version/RenderFieldsToDiff/fields/Nested/index.tsx # packages/next/src/views/Version/RenderFieldsToDiff/fields/Tabs/index.tsx # packages/next/src/views/Version/RenderFieldsToDiff/fields/types.ts # packages/next/src/views/Version/RenderFieldsToDiff/index.tsx

…n-diff-view' into feat/modified-fields-only-version-diff-view # Conflicts: # packages/next/src/views/Version/RenderFieldsToDiff/fields/Iterable/index.tsx # packages/next/src/views/Version/RenderFieldsToDiff/fields/Nested/index.tsx # packages/next/src/views/Version/RenderFieldsToDiff/fields/Tabs/index.tsx

DanRibbens

Looks good overall. Few questions on code, plus I'm wondering why the updated timestamp isn't showing after checking the Modified only option?

packages/next/src/views/Version/Default/index.scss

packages/translations/src/languages/zhTw.ts

tsemachh · 2025-01-28T04:39:58Z

Looks good overall. Few questions on code, plus I'm wondering why the updated timestamp isn't showing after checking the Modified only option?

From user perspective the timestamp(Any potentially other audit fields) were not modified by the user so I thought it's better not to show them on the diff , if you think this should change I will change it,

…-diff-view

…-only-version-diff-view

…n-diff-view' into feat/modified-fields-only-version-diff-view

tsemachh · 2025-01-28T07:22:25Z

@DanRibbens I replied and fixed the CSS , let me know if more changes are needed - thank you

DanRibbens · 2025-01-28T11:08:35Z

My expectation is that any data that has changed it would show. Can you make that adjustment?

DanRibbens

This is great. I'm just waiting for the updated at change and then we can finally get this merged. Thanks for being extra patient.

tsemachh · 2025-01-28T11:25:57Z

My expectation is that any data that has changed it would show. Can you make that adjustment?

@DanRibbens done

DanRibbens · 2025-01-28T11:29:45Z

I'm confused, field.admin.hidden was used to hide the updatedAt field?

I don't understand that last commit.

Fields with admin.hidden: true should not show in diffs. I was mistaken.

tsemachh · 2025-01-28T19:05:27Z

I'm confused, field.admin.hidden was used to hide the updatedAt field?

I don't understand that last commit.

Fields with admin.hidden: true should not show in diffs. I was mistaken.
@DanRibbens
Yes , not only the updateAt , if we have other audit fields they were also hidden in this case
I reverted it back to previous code , now we hide admin.hidden fields
(Also resolved conflict , you are really fast)

…-only-version-diff-view # Conflicts: # packages/next/src/views/Version/RenderFieldsToDiff/index.tsx

DanRibbens · 2025-01-28T20:31:47Z

I'm about to push the fix for the build error and add the missing translations.

github-actions · 2025-01-29T15:49:38Z

🚀 This is included in version v3.20.0

tsemachh added 10 commits October 13, 2024 12:11

feat/modified-fields-only-version-diff

b67c332

Fix position of checkbox

1281790

Change to dequal from lodash

296de8c

feat/modified-fields-only-version-diff

5b3fa43

feat/modified-fields-only-version-diff

2ecc740

feat/modified-fields-only-version-diff

b616dc7

feat/modified-fields-only-version-diff

8d595ea

LIne Up

1410b3a

tsemachh changed the title ~~Feat/modified fields only version diff view~~ feat(ui)/modified fields only version diff view Jan 26, 2025

tsemachh changed the title ~~feat(ui)/modified fields only version diff view~~ feat(ui):modified fields only version diff view Jan 26, 2025

AlessioGr changed the title ~~feat(ui):modified fields only version diff view~~ feat(ui): toggle showing only modified fields in version diff view Jan 27, 2025

DanRibbens requested changes Jan 27, 2025

View reviewed changes

packages/next/src/views/Version/Default/index.scss Outdated Show resolved Hide resolved

packages/translations/src/languages/zhTw.ts Outdated Show resolved Hide resolved

tsemachh added 4 commits January 28, 2025 06:42

Merge branch 'payloadcms:main' into feat/modified-fields-only-version…

12c7373

…-diff-view

Merge remote-tracking branch 'payload/main' into feat/modified-fields…

81f9c4a

…-only-version-diff-view

Fix Css top use vars as restore does

0e6bda9

Merge remote-tracking branch 'origin/feat/modified-fields-only-versio…

734c198

…n-diff-view' into feat/modified-fields-only-version-diff-view

DanRibbens requested changes Jan 28, 2025

View reviewed changes

Show also admin fields

823ebfa

tsemachh added 2 commits January 28, 2025 21:11

Rolback the fix to show the admin.hidden

28dc344

Merge remote-tracking branch 'payload/main' into feat/modified-fields…

b835410

…-only-version-diff-view # Conflicts: # packages/next/src/views/Version/RenderFieldsToDiff/index.tsx

chore: translations for versions.modifiedOnly

8bb444f

DanRibbens added 2 commits January 28, 2025 15:53

chore: type error in next versions tabs field modifiedOnly

05ee864

chore: show admin hidden when displaying modifiedOnly versions

5305b36

DanRibbens approved these changes Jan 28, 2025

View reviewed changes

DanRibbens enabled auto-merge (squash) January 28, 2025 21:01

DanRibbens merged commit 33ac13d into payloadcms:main Jan 28, 2025
67 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ui): toggle showing only modified fields in version diff view #10807

feat(ui): toggle showing only modified fields in version diff view #10807

tsemachh commented Jan 26, 2025

DanRibbens left a comment

tsemachh commented Jan 28, 2025

tsemachh commented Jan 28, 2025

DanRibbens commented Jan 28, 2025

DanRibbens left a comment

tsemachh commented Jan 28, 2025

DanRibbens commented Jan 28, 2025 •

edited

Loading

tsemachh commented Jan 28, 2025 •

edited

Loading

DanRibbens commented Jan 28, 2025

github-actions bot commented Jan 29, 2025

feat(ui): toggle showing only modified fields in version diff view #10807

feat(ui): toggle showing only modified fields in version diff view #10807

Conversation

tsemachh commented Jan 26, 2025

Description

Type of change

Checklist:

DanRibbens left a comment

Choose a reason for hiding this comment

tsemachh commented Jan 28, 2025

tsemachh commented Jan 28, 2025

DanRibbens commented Jan 28, 2025

DanRibbens left a comment

Choose a reason for hiding this comment

tsemachh commented Jan 28, 2025

DanRibbens commented Jan 28, 2025 • edited Loading

tsemachh commented Jan 28, 2025 • edited Loading

DanRibbens commented Jan 28, 2025

github-actions bot commented Jan 29, 2025

DanRibbens commented Jan 28, 2025 •

edited

Loading

tsemachh commented Jan 28, 2025 •

edited

Loading