Make _danger-local-https feature additive #430
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://doc.rust-lang.org/cargo/reference/features.html#feature-unification
"Rust features should be additive. That is, enabling a feature should not disable functionality, and it should usually be safe to enable any combination of features"
Before this change
io::fetch_ohttp_keys
changed its signature based on the feature flag. I noticed downstream that this creates a feature flag mess in bindings and it's one opportunity to address tech debt.This begins to address #392