Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make _danger-local-https feature additive #430

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanGould
Copy link
Contributor

@DanGould DanGould commented Dec 4, 2024

See: https://doc.rust-lang.org/cargo/reference/features.html#feature-unification

"Rust features should be additive. That is, enabling a feature should not disable functionality, and it should usually be safe to enable any combination of features"

Before this change io::fetch_ohttp_keys changed its signature based on the feature flag. I noticed downstream that this creates a feature flag mess in bindings and it's one opportunity to address tech debt.

This begins to address #392

@DanGould DanGould force-pushed the additive-danger-local-https branch from 6b17604 to 05d0406 Compare December 4, 2024 20:01
See: <https://doc.rust-lang.org/cargo/reference/features.html#feature-unification>

"Rust features should be *additive*. That is, enabling a feature should
not disable functionality, and it should usually be safe to enable any
combination of features"

Before this change `io::fetch_ohttp_keys` changed its signature based
on the feature flag. I noticed downstream that this creates a feature
flag mess in bindings and it's one opportunity to address tech debt.
@coveralls
Copy link
Collaborator

coveralls commented Dec 4, 2024

Pull Request Test Coverage Report for Build 12167347639

Details

  • 7 of 16 (43.75%) changed or added relevant lines in 2 files are covered.
  • 26 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.5%) to 61.396%

Changes Missing Coverage Covered Lines Changed/Added Lines %
payjoin/src/io.rs 7 11 63.64%
payjoin-cli/src/app/v2.rs 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
payjoin/src/receive/error.rs 1 1.46%
payjoin/src/send/mod.rs 4 92.48%
payjoin/src/receive/mod.rs 5 90.31%
payjoin/src/psbt.rs 7 46.56%
payjoin/src/io.rs 9 36.17%
Totals Coverage Status
Change from base Build 12163677379: -0.5%
Covered Lines: 2850
Relevant Lines: 4642

💛 - Coveralls

@DanGould DanGould marked this pull request as draft December 4, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants