Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide danger-local-https feature with _ prefix #423

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

DanGould
Copy link
Contributor

@DanGould DanGould commented Dec 2, 2024

This prevents it from showing up in docs.rs documentation

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12128875459

Details

  • 1 of 5 (20.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 61.516%

Changes Missing Coverage Covered Lines Changed/Added Lines %
payjoin-cli/src/app/v1.rs 0 2 0.0%
payjoin-cli/src/app/v2.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
payjoin/src/send/mod.rs 2 92.78%
Totals Coverage Status
Change from base Build 12086002692: -0.05%
Covered Lines: 2791
Relevant Lines: 4537

💛 - Coveralls

@nothingmuch
Copy link
Collaborator

  • 1 of 5 (20.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 61.516%

image

Copy link
Collaborator

@nothingmuch nothingmuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, coverall's "changed" lines are noise and presumably an analysis bug on their side? not sure what's going on there but the "new" lines clearly existed before, and unchanged the "lost coverage" lines are just attrs

manually verified that git grep '[^_]danger-local-https' has no matches as expected

@DanGould DanGould merged commit 1b15337 into payjoin:master Dec 3, 2024
6 checks passed
@DanGould DanGould deleted the hide-danger-local-https branch December 3, 2024 02:08
@DanGould DanGould mentioned this pull request Dec 3, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants