Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump payjoin version to 0.21.0 #415

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Bump payjoin version to 0.21.0 #415

merged 1 commit into from
Dec 3, 2024

Conversation

DanGould
Copy link
Contributor

@DanGould DanGould commented Nov 27, 2024 •
edited
Loading

We should really get #417, #373, and perhaps #413 in before release candidate in order to prevent future breaking changes

@coveralls
Copy link
Collaborator

coveralls commented Nov 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12132229311

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 61.826%
Files with Coverage Reduction New Missed Lines %
payjoin/src/send/mod.rs 2 92.78%
Totals Coverage Status
Change from base Build 12132019366: -0.04%
Covered Lines: 2865
Relevant Lines: 4634
💛 - Coveralls

@DanGould DanGould marked this pull request as ready for review December 3, 2024 03:18
@DanGould
Copy link
Contributor Author

DanGould commented Dec 3, 2024 •
edited
Loading

@nothingmuch I think we made it. I don't think we need an rc unless we need test utils in this one. what say you?

@DanGould DanGould requested a review from spacebear21 December 3, 2024 17:04
spacebear21
spacebear21 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9d937bc

@DanGould DanGould merged commit 41de968 into payjoin:master Dec 3, 2024
6 checks passed
@DanGould DanGould deleted the bump-payjoin-0-21 branch December 3, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacebear21 spacebear21 spacebear21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanGould @coveralls @spacebear21