Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on bitcoin-ohttp #354

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Depend on bitcoin-ohttp #354

merged 1 commit into from
Sep 5, 2024

Conversation

DanGould
Copy link
Contributor

@DanGould DanGould commented Sep 4, 2024

  • Depend on bitcoin-ohttp which in turn depends on bitcoin-hpke and libsecp256k1 C bindings
  • Depend on bitcoin-hpke for client-client aead
  • compress secp256k1 keys when base64url serialized

supersedes #227

Which in turn depends on bitcoin-hpke and libsecp256k1 C bindings
@DanGould DanGould mentioned this pull request Sep 4, 2024
@DanGould DanGould added this to the Payjoin V2 beta milestone Sep 4, 2024
@DanGould DanGould marked this pull request as ready for review September 5, 2024 15:57
@DanGould DanGould requested a review from spacebear21 September 5, 2024 15:57
@DanGould
Copy link
Contributor Author

DanGould commented Sep 5, 2024

While I do plan to depend on bitcoin-hpke for client-client aead and compress secp256k1 keys when base64url serialized, I think this PR can be reviewed in isolation (as long as the next release includes all 3 changes at once)

Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@DanGould DanGould merged commit 3201ed6 into payjoin:master Sep 5, 2024
4 checks passed
@DanGould DanGould changed the title Depend on bitcoin-hpke Depend on bitcoin-ohttp Sep 5, 2024
@DanGould DanGould deleted the bitcoin-hpke branch September 5, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants