Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-10014 Arquillian HTTPS Support #249

Merged
merged 4 commits into from
Nov 22, 2024
Merged

FISH-10014 Arquillian HTTPS Support #249

merged 4 commits into from
Nov 22, 2024

Conversation

jGauravGupta
Copy link
Contributor

@jGauravGupta jGauravGupta commented Nov 22, 2024 •
edited
Loading

Summary

  • Added HTTPS support configurable via:
    • System property: httpsEnabled
    • arquillian.xml property: httpsEnabled
  • Renamed adminHttps to adminHttpsEnabled for naming consistency.

breakponchito
breakponchito approved these changes Nov 22, 2024
View reviewed changes
Copy link

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jGauravGupta
Copy link
Contributor Author

Test failure in microprofile/pom.xml is expected.

@jGauravGupta jGauravGupta merged commit d4fc8e7 into payara:Payara7 Nov 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breakponchito breakponchito breakponchito approved these changes

@luiseufrasio luiseufrasio Awaiting requested review from luiseufrasio

@Pandrex247 Pandrex247 Awaiting requested review from Pandrex247

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jGauravGupta @breakponchito