Small adjustments for port serial opening

paveldn · Mar 25, 2024 · c11dfa8 · c11dfa8
1 parent c6ed7d5
commit c11dfa8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 17 deletions.
diff --git a/tools/remote_serial_bridge/main.cpp b/tools/remote_serial_bridge/main.cpp
@@ -77,13 +77,7 @@ int main(int argc, char** argv) {
     }
     HAIER_LOGI("Opening port %s", argv[1]);
     haier_protocol::set_log_handler(console_logger);
-    std::string port_path;
-#if _WIN32
-    port_path = std::string("\\\\.\\").append(argv[1]);
-#else
-    port_path = argv[1];
-#endif
-    SerialStream serial_stream(port_path.c_str());
+    SerialStream serial_stream(argv[1]);
     if (!serial_stream.is_valid()) {
       std::cout << "Can't open port " << argv[1] << std::endl;
       return 1;

diff --git a/tools/utils/serial_stream.cpp b/tools/utils/serial_stream.cpp
@@ -9,7 +9,11 @@
 
 SerialStream::SerialStream(const std::string& port_path) : buffer_(SERIAL_BUFFER_SIZE) {
 #if _WIN32
-    handle_ = CreateFile(port_path.c_str(), GENERIC_READ | GENERIC_WRITE, 0, 0, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, 0);
+    constexpr char win_prefix[] = "\\\\.\\";
+    std::string port_win = port_path;
+    if (port_win.rfind(win_prefix, 0) != 0)
+        port_win = std::string(win_prefix).append(port_win);
+    handle_ = CreateFile(port_win.c_str(), GENERIC_READ | GENERIC_WRITE, 0, 0, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, 0);
     if (is_valid()) {
         DCB serialParams = { 0 };
         serialParams.DCBlength = sizeof(serialParams);
@@ -63,8 +67,8 @@ SerialStream::SerialStream(const std::string& port_path) : buffer_(SERIAL_BUFFER
       cfsetispeed(&tty, B9600);
       cfsetospeed(&tty, B9600);
       if (tcsetattr(handle_, TCSANOW, &tty) != 0) {
-      handle_ = -1;
-      return;
+        handle_ = -1;
+        return;
       }
     }
 #endif

diff --git a/tools/utils/simulator_base.cpp b/tools/utils/simulator_base.cpp
@@ -42,13 +42,7 @@ void simulator_main(const char* app_name, const char* port_name, message_handler
 
 void simulator_main(const char* app_name, const char* port_name, message_handlers mhandlers, answer_handlers ahandlers, keyboard_handlers khandlers, protocol_preloop ploop) {
   haier_protocol::set_log_handler(console_logger);
-  std::string port_path;
-#if _WIN32
-  port_path = std::string("\\\\.\\").append(port_name);
-#else
-  port_path = port_name;
-#endif
-  SerialStream serial_stream(port_path.c_str());
+  SerialStream serial_stream(port_name);
   if (!serial_stream.is_valid()) {
     std::cout << "Can't open port " << port_name << std::endl;
     return;