Provider update #429
Open
Provider update #429
+823
−409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalk-hwang
suggested changes
Oct 24, 2024
| @@ -372,6 +379,7 @@ func toPortOverride(data map[string]interface{}) (unifi.DevicePortOverrides, err | |||
| OpMode: opMode, | |||
| PoeMode: poeMode, | |||
| AggregateNumPorts: aggregateNumPorts, | |||
| NATiveNetworkID: nativeNetworkID, | |||
There was a problem hiding this comment.
Suggested change
| NATiveNetworkID: nativeNetworkID, | |
| NativeNetworkID: nativeNetworkID, |
| @@ -383,6 +391,7 @@ func fromPortOverride(po unifi.DevicePortOverrides) (map[string]interface{}, err | |||
| "op_mode": po.OpMode, | |||
| "poe_mode": po.PoeMode, | |||
| "aggregate_num_ports": po.AggregateNumPorts, | |||
| "native_network_id": po.NATiveNetworkID, | |||
There was a problem hiding this comment.
Suggested change
| "native_network_id": po.NATiveNetworkID, | |
| "native_network_id": po.NativeNetworkID, |
| Isolation: d.Get("isolation").(bool), | ||
| LldpmedEnabled: d.Get("lldpmed_enabled").(bool), | ||
| LldpmedNotifyEnabled: d.Get("lldpmed_notify_enabled").(bool), | ||
| NATiveNetworkID: d.Get("native_networkconf_id").(string), |
There was a problem hiding this comment.
Suggested change
| NATiveNetworkID: d.Get("native_networkconf_id").(string), | |
| NativeNetworkID: d.Get("native_networkconf_id").(string), |
| LldpmedEnabled bool `json:"lldpmed_enabled,omitempty"` | ||
| LldpmedNotifyEnabled bool `json:"lldpmed_notify_enabled,omitempty"` | ||
| MirrorPortIDX int `json:"mirror_port_idx,omitempty"` // [1-9]|[1-4][0-9]|5[0-2] | ||
| NATiveNetworkID string `json:"native_networkconf_id,omitempty"` |
There was a problem hiding this comment.
Suggested change
| NATiveNetworkID string `json:"native_networkconf_id,omitempty"` | |
| NativeNetworkID string `json:"native_networkconf_id,omitempty"` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bundles a couple of updates:
I've also published a version of this provider from my fork that incorporates the above: https://registry.terraform.io/providers/akerl/unifi/latest
I did this largely for my own benefit, since I use this module and didn't want to have to manually install it, but if it's useful for other folks, all the better.