Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support access options in Unifi network payload #280

Closed
wants to merge 2 commits into from
Closed

Support access options in Unifi network payload #280

wants to merge 2 commits into from

Conversation

DillonN
Copy link
Contributor

@DillonN DillonN commented Oct 16, 2022

See #279. These options were always being set to false, which caused Unifi to block internet access.

I'm not 100% sure what effect these have on the WAN networks, and they're getting applied there as well. It doesn't seem to change anything. I think ideally though these would be empty in the payload, which is how the Unifi console creates networks (both WAN and LAN).

@carlallen
Copy link

@paultyng this is a huge issue which basically makes the terraform module unusable. This needs to get merged as soon as possible.

I got hit by this yesterday and the troubleshooting took down my network for hours. I can't imagine the impact if this were to be used by a small business instead of just a home user like me.

@paultyng
Copy link
Owner

@DillonN thanks for the fix and @carlallen thanks for tagging me on this and really sorry about the troubleshooting time sink there. I just kicked off the tests and if green will merge and cut a new hotfix version.

This is related to paultyng/go-unifi#53 as well. We should probably look at defaulting most bools in the provider to sane defaults to avoid this kind of situation.

@paultyng paultyng linked an issue Oct 19, 2022 that may be closed by this pull request
@carlallen
Copy link

@paultyng looks like lots of failing tests, since all this is now going to be in the state.

@paultyng
Copy link
Owner

Looks like a couple reasons for failing tests, some are 7.2 and a newer way of handling wlan min rates, so trying to clear that up. Also modifying the SDK to handle the defaulting to true a bit better. Going to see if I can get this working in #282

@paultyng
Copy link
Owner

I've merged #282 that is this plus some other misc fixes.

@paultyng paultyng closed this Oct 20, 2022
@paultyng
Copy link
Owner

Released in v0.35.0

@DillonN DillonN deleted the fix/279-support-new-access-opts branch October 21, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Networks created through the provider are blocked from internet access
3 participants