test: label tests dir as having sideEffects=true #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package is labelled as
sideEffects=false
:noble-ed25519/package.json
Lines 10 to 14 in 0a2838f
That shouldn't apply to tests, because of:
noble-ed25519/test/ed25519.webcrypto.test.js
Line 5 in 0a2838f
noble-ed25519/test/ed25519.helpers.js
Line 8 in 0a2838f
Adding
sideEffects=true
to the test dir makes tests suitable for running in bundled modeTo test:
npm test
npx @exodus/test
(Node.js)npx @exodus/test --engine jsc:bundle --bundle-entropy-size=1000000
(JSC)Requires
jsc
available in PATHnpx @exodus/test --engine hermes:bundle --bundle-entropy-size=1000000
(Hermes)Requires
hermes
available in PATH or https://npmjs.com/hermes-engine-cli installed with@exodus/test
:npm add @exodus/test hermes-engine-cli
Refs: paulmillr/noble-curves#166