Check for Basepath only once at start of remote parms loop.

paulhibbitts · Aug 21, 2023 · ea2a553 · ea2a553
1 parent 6c3d228
commit ea2a553
Showing 1 changed file with 17 additions and 18 deletions.
diff --git a/docs/index.html b/docs/index.html
@@ -1151,7 +1151,7 @@
 
               if (getURLParameterByName('font-family')) {
                 fontfamily = getURLParameterByName('font-family', null, null, window.location.href, true);
-                document.getElementById('fontfamily').value = fontfamily;
+                document.getElementById('fontfamily').value = encodeURI(fontfamily);
               }
 
               if (getURLParameterByName('font-size')) {
@@ -1311,26 +1311,25 @@
 
     <!-- Credit to Beau Shaw for dymamic remote docsify technique -->
     <!-- To render a Markdown file named ** README.md ** (the expected default name) the URL would be https://hibbitts-design.github.io/test-docsify-project-docs/?basePath=https://raw.githubusercontent.com/hibbitts-design/docsify-open-course-starter-kit/main -->
-    const params = new URLSearchParams(window.location.search);
-    params.forEach((value, key) => {
-      // TODO: Parse numbers?
-
-      // console.log(value,key);
-      if (key === 'basePath' && !(allowedDomains === '')) {
-        const { hostname } = new URL(value);
-        if (!(allowedDomains.includes(hostname))) {
-          alert('Only the domain(s) ' + allowedDomains + ' permitted for a Markdown source file URL.');
-          throw new Error('Only the domain ' + allowedDomains + ' permitted for a Markdown source file URL.');
+    if (getURLParameterByName('basePath')) {
+      const params = new URLSearchParams(window.location.search);
+      params.forEach((value, key) => {
+        // TODO: Parse numbers?
+
+        // console.log(value,key);
+        if (key === 'basePath' && !(allowedDomains === '')) {
+          const { hostname } = new URL(value);
+          if (!(allowedDomains.includes(hostname))) {
+            alert('Only the domain(s) ' + allowedDomains + ' permitted for a Markdown source file URL.');
+            throw new Error('Only the domain ' + allowedDomains + ' permitted for a Markdown source file URL.');
+          } else {
+            window.$docsify[key] = value;
+          }
         } else {
           window.$docsify[key] = value;
         }
-      } else {
-        // ensure to only load when displaying remote files
-        if (getURLParameterByName('basePath')) {
-        window.$docsify[key] = value;
-        }
-      }
-    });
+      });
+    }
 
     // If switch of light/dark theme mode
     window.matchMedia('(prefers-color-scheme: dark)').addListener(function (e) {