Webpack 2 migration, package updates #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PF updated to latest v3.23.3 Project now uses webpack v2 Webpack loader and plugin upgrades Deprecated autoprefixer-loader has been replaced with postcss-loader npm clean scipt now uses rimraf instead of rm; now will also work in windows Minor modifications to source js to accommodate these changes
Patternfly node-modules should take precedence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi maintainers,
I have created this version with the following changes:
npm run cleannow usesrimrafinstead ofrm, this makes the command platform independentTo accommodate these changes minor edits were necessary in the main.js and chart.js files.
Let me know if there are any issues with this PR.
Thanks & Cheers,
Subha