Add support for response.raw attribute. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| try: | ||
| from cStringIO import StringIO | ||
| except ImportError: | ||
| from io import StringIO |
There was a problem hiding this comment.
Won't you need a third fallback here for from StringIO import StringIO on Python 2 platforms that do not support cStringIO?
|
I feel this implementation is incorrect. It should use BytesIO and not StringIO, so that r.raw.read() returns bytes on Python 3. I'm working on a patch for it. |
|
You are correct. I should have used BytesIO for Python 2 and 3 compatibility. |
|
Any news here? ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response objects in requests are documented to contain a
rawattribute that is a file-like object. When the request is made withstream=True, therawattribute can be read to stream in the content. Otherwise, therawattribute looks like a file-like object with no bytes left to read.This PR adds support for the raw attribute and its behavior (at least how requests behaves currently).