Automatically build and publish container images to Github Container Repo #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
reviewed
Feb 15, 2024
| RUN go mod tidy | ||
| RUN go build . | ||
|
|
||
| FROM docker.io/debian:stable-slim |
There was a problem hiding this comment.
Let's add OCI annotations, to provide helpful machine-readable infos to a variety of tools.
Suggested change
| FROM docker.io/debian:stable-slim | |
| FROM docker.io/debian:stable-slim | |
| LABEL org.opencontainers.image.title="oxygen-xml" | |
| LABEL org.opencontainers.image.description="A tool for checking, sanitizing and minimizing GTFS feeds." | |
| LABEL org.opencontainers.image.authors="Patrick Brosi <[email protected]>" | |
| LABEL org.opencontainers.image.source="https://github.com/patrickbr/gtfstidy" |
There was a problem hiding this comment.
docker/metadata-action actually already adds most (all?) of these labels from the GitHub metadata.
Can you check the pfaedle image (which uses the same process) to see if you're missing something? https://github.com/ad-freiburg/pfaedle/pkgs/container/pfaedle
There was a problem hiding this comment.
Thanks, I didn't know. Consider this thread irrelevant then.
derhuerst
added a commit
to public-transport/transitous
that referenced
this pull request
Feb 26, 2024
to benefit from layer caching related: patrickbr/gtfstidy#23
|
Would it be possible to get a review for this? |
|
Hello, it's me again. Can I get a review for this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like the PR over at pfaedle, this one automatically builds container images for this repo and deploys them to Github Container Repo.
You can see an example here: https://github.com/leonardehrenfried/gtfstidy/pkgs/container/gtfstidy
A complete example of how to use it would be:
Do you want me to add that to the documentation?