Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temperature initialization in SimConfig #606

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

a-corni
Copy link
Collaborator

@a-corni a-corni commented Nov 8, 2023

Fixing the way temperature is converted from µK to K since it was generating bugs with float.
Closes #604

@a-corni a-corni requested a review from madagra November 8, 2023 11:13
@a-corni a-corni changed the title Fix temperature initialization Fix temperature initialization in SimConfig Nov 8, 2023
Copy link
Collaborator

@madagra madagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@a-corni a-corni merged commit 9f9a17a into develop Nov 8, 2023
6 checks passed
@HGSilveri HGSilveri mentioned this pull request Dec 1, 2023
HGSilveri pushed a commit that referenced this pull request Dec 4, 2023
Main changes:
a0c59a6 Deprecate legacy devices (#620)
b18e434 FIX: Detuning modulation for custom EOM buffer time (#619)
8c5d966 Delete summing constraint in DetuningMap (#610)
b41d62a JSON serialization support for numpy integer types (#617)
9f9a17a Fix temperature initialization in SimConfig (#606)
2bad427 Fix spacing in register.max_connectivity (#605)
581886f [FIX] Allow parametrized phase in EOM mode (#599)
394fe6a Add `wait` option to remote backends (#598)
@HGSilveri HGSilveri deleted the temperature_sim branch December 29, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling of temperature in SimConfig
2 participants