Skip to content

Commit

Permalink
customer review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
parvathika committed Nov 13, 2024
1 parent 5e48ca7 commit bf4b76b
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 266 deletions.
17 changes: 3 additions & 14 deletions .github/workflows/gnome_unit_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,9 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
compiler: [ gcc, clang ]
coverage: [ with-coverage, without-coverage ]
exclude:
- compiler: clang
coverage: with-coverage
- compiler: clang
coverage: without-coverage
- compiler: gcc
coverage: without-coverage

compiler: [ gcc ]
coverage: [ with-coverage ]

steps:
- name: Configure cache
if: ${{ !env.ACT }}
Expand Down Expand Up @@ -101,10 +94,6 @@ jobs:
uses: actions/checkout@v3
with:
path: networkmanager

- name: Set clang toolchain
if: ${{ matrix.compiler == 'clang' }}
run: echo "TOOLCHAIN_FILE=${{github.workspace}}/networkmanager/Tests/clang.cmake" >> $GITHUB_ENV

- name: Set gcc/with-coverage toolchain
if: ${{ matrix.compiler == 'gcc' && matrix.coverage == 'with-coverage' && !env.ACT }}
Expand Down
12 changes: 0 additions & 12 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,3 @@ if(ENABLE_UNIT_TESTING)
include(Tests/unittest/tests.cmake)
endif(ENABLE_UNIT_TESTING)

if (ENABLE_CODE_COVERAGE)
include (CodeCoverage)
option (ENABLE_UNIT_TESTING "ENABLE_UNIT_TESTING" ON)
if (BUILD_FOR_DESKTOP)
if (ENABLE_CODE_COVERAGE_GOVR)
setup_target_for_coverage_gcovr_html(NAME "${PROJECT_NAME}CodeCoverageUI")
setup_target_for_coverage_gcovr_xml(NAME "${PROJECT_NAME}CodeCoverage")
else ()
setup_target_for_coverage_lcov(NAME "${PROJECT_NAME}CodeCoverageUI")
endif()
endif()
endif()
181 changes: 0 additions & 181 deletions Tests/unittest/.lcovrc_l1

This file was deleted.

59 changes: 0 additions & 59 deletions Tests/unittest/test_connectivity.cpp

This file was deleted.

0 comments on commit bf4b76b

Please sign in to comment.