Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev boxed variant #536

Draft
wants to merge 6 commits into
base: feat-paramaterized-equality
Choose a base branch
from
Draft

Conversation

jpschorr
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Jan 14, 2025

Conformance comparison report

Base (db26def) 3f614f4 +/-
% Passing 86.97% 87.15% 0.19%
✅ Passing 5591 5603 12
❌ Failing 838 826 -12
🔶 Ignored 0 0 0
Total Tests 6429 6429 0

Number passing in both: 5591

Number failing in both: 826

Number passing in Base (db26def) but now fail: 0

Number failing in Base (db26def) but now pass: 12

The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:

Click here to see
  • partiql_tests::eval::ion::primitives::primitives::functions::exists::exists::strict_exists_valid_cases_param_missing_result_true_
  • partiql_tests::eval::ion::primitives::primitives::functions::exists::exists::permissive_exists_valid_cases_param_result_false_
  • partiql_tests::eval::ion::primitives::primitives::functions::exists::exists::permissive_exists_valid_cases_param_missing_result_true_
  • partiql_tests::eval::ion::primitives::primitives::functions::exists::exists::permissive_exists_valid_cases_param_1_result_true_
  • partiql_tests::eval::ion::primitives::primitives::functions::exists::exists::strict_exists_valid_cases_param_result_false_
  • partiql_tests::eval::ion::query::query::select::projection::project_various_container_types::strict_project_of_sexp
  • partiql_tests::eval::ion::primitives::primitives::functions::exists::exists::strict_exists_valid_cases_param_null_result_true_
  • partiql_tests::eval::ion::query::query::select::from_clause::various_types_in_from_clause::strict_range_over_sexp
  • partiql_tests::eval::ion::query::query::select::projection::project_various_container_types::permissive_project_of_sexp
  • partiql_tests::eval::ion::primitives::primitives::functions::exists::exists::permissive_exists_valid_cases_param_null_result_true_
  • partiql_tests::eval::ion::query::query::select::from_clause::various_types_in_from_clause::permissive_range_over_sexp
  • partiql_tests::eval::ion::primitives::primitives::functions::exists::exists::strict_exists_valid_cases_param_1_result_true_

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 58.70902% with 403 lines in your changes missing coverage. Please review.

Project coverage is 80.12%. Comparing base (375abaa) to head (babeb5f).

Files with missing lines Patch % Lines
extension/partiql-extension-ion/src/boxed_ion.rs 55.72% 194 Missing and 11 partials ⚠️
extension/partiql-extension-ion/src/decode.rs 56.43% 36 Missing and 8 partials ⚠️
partiql-value/src/variant.rs 66.95% 37 Missing and 1 partial ⚠️
partiql-value/src/datum.rs 22.85% 27 Missing ⚠️
partiql-value/src/value.rs 48.88% 21 Missing and 2 partials ⚠️
partiql-value/src/boxed_variant.rs 41.66% 21 Missing ⚠️
partiql-eval/src/plan.rs 72.91% 8 Missing and 5 partials ⚠️
extension/partiql-extension-ion/src/util.rs 88.00% 5 Missing and 4 partials ⚠️
partiql-eval/src/eval/expr/mod.rs 0.00% 6 Missing ⚠️
partiql-eval/src/eval/eval_expr_wrapper.rs 50.00% 5 Missing ⚠️
... and 6 more
Additional details and impacted files
@@                       Coverage Diff                       @@
##           feat-paramaterized-equality     #536      +/-   ##
===============================================================
- Coverage                        81.18%   80.12%   -1.06%     
===============================================================
  Files                               90       95       +5     
  Lines                            19730    20607     +877     
  Branches                         19730    20607     +877     
===============================================================
+ Hits                             16017    16511     +494     
- Misses                            3293     3651     +358     
- Partials                           420      445      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpschorr jpschorr force-pushed the feat-shape-category branch 2 times, most recently from b74749f to e93ee2e Compare January 14, 2025 21:39
@jpschorr jpschorr force-pushed the feat-shape-category branch from e93ee2e to d9dee1f Compare January 14, 2025 21:49
Base automatically changed from feat-shape-category to main January 14, 2025 23:22
@jpschorr jpschorr changed the base branch from main to feat-paramaterized-equality January 15, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant