Add validation for comparison operations #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5731 Number failing in both: 611 Number passing in Base (36b90c5) but now fail: 0 Number failing in Base (36b90c5) but now pass: 1 The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass: Click here to see
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
==========================================
+ Coverage 80.78% 80.84% +0.05%
==========================================
Files 80 80
Lines 19338 19398 +60
Branches 19338 19398 +60
==========================================
+ Hits 15623 15683 +60
Misses 3291 3291
Partials 424 424 ☔ View full report in Codecov by Sentry. |
jpschorr
force-pushed
the
feat-strict-comp-ops
branch
2 times, most recently
from
4e05f89 to
41c8bc7
Compare
jpschorr
force-pushed
the
feat-strict-comp-ops
branch
from
41c8bc7 to
52e9ca4
Compare
alancai98
approved these changes
Oct 10, 2024
partiql-value/src/lib.rs
Outdated
| @@ -6,7 +6,7 @@ use std::cmp::Ordering; | |||
|
|
|||
| use std::borrow::Cow; | |||
|
|
|||
| use std::fmt::{Debug, Formatter}; | |||
| use std::fmt::{Debug, Display, Formatter, Write}; | |||
There was a problem hiding this comment.
copying the clippy warning:
unused import: `Write`
warning: unused import: `Write`
--> partiql-value/src/lib.rs:9:43
|
9 | use std::fmt::{Debug, Display, Formatter, Write};
| ^^^^^
|
= note: `#[warn(unused_imports)]` on by default
partiql-value/src/lib.rs
Outdated
| fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { | ||
| match self.to_pretty_string(f.width().unwrap_or(80)) { | ||
| Ok(pretty) => f.write_str(&pretty), | ||
| Err(err) => f.write_str("<internal value error occurred>"), |
There was a problem hiding this comment.
copying the clippy warning
unused variable: `err`
warning: unused variable: `err`
--> partiql-value/src/lib.rs:68:17
|
68 | Err(err) => f.write_str("<internal value error occurred>"),
| ^^^ help: if this is intentional, prefix it with an underscore: `_err`
|
= note: `#[warn(unused_variables)]` on by default
| Ok(_) => ControlFlow::Continue(result), | ||
| Err(value) => { | ||
| if STRICT { | ||
| // TODO better error messages |
There was a problem hiding this comment.
Could this be addressed in this PR? Otherwise can track in a separate issue?
am357
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #506
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.