Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to pretty-printing for AND/OR/CASE #482

Merged
merged 3 commits into from
Jul 31, 2024

Add pretty-print roundtrip tests and Fix PIVOT pretty-print

6b546aa
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Improvements to pretty-printing for AND/OR/CASE #482

Add pretty-print roundtrip tests and Fix PIVOT pretty-print
6b546aa
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Jul 31, 2024 in 1s

clippy

18 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 18
Note 0
Help 0

Versions

  • rustc 1.80.0 (051478957 2024-07-21)
  • cargo 1.80.0 (376290515 2024-07-16)
  • clippy 0.1.80 (0514789 2024-07-21)

Annotations

Check warning on line 23 in partiql-conformance-tests/src/bin/generate_comparison_report.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item missing indentation

warning: doc list item missing indentation
  --> partiql-conformance-tests/src/bin/generate_comparison_report.rs:23:5
   |
23 | /// regressed behavior)
   |     ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
   = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
   |
23 | ///   regressed behavior)
   |     ++

Check warning on line 149 in partiql-eval/src/eval/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `serde`

warning: unexpected `cfg` condition value: `serde`
   --> partiql-eval/src/eval/mod.rs:149:12
    |
149 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
    |            ^^^^^^^^^^^^^^^^^ help: remove the condition
    |
    = note: no expected values for `feature`
    = help: consider adding `serde` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
    = note: `#[warn(unexpected_cfgs)]` on by default

Check warning on line 164 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:164:13
    |
163 |     pub struct EvaluationFailAssertion {
    |                ----------------------- field in this struct
164 |         pub result: String,
    |             ^^^^^^
    |
    = note: `EvaluationFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 157 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:157:13
    |
156 |     pub struct EvaluationSuccessAssertion {
    |                -------------------------- field in this struct
157 |         pub result: String,
    |             ^^^^^^
    |
    = note: `EvaluationSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 152 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:152:13
    |
151 |     pub struct StaticAnalysisFailAssertion {
    |                --------------------------- field in this struct
152 |         pub result: String,
    |             ^^^^^^
    |
    = note: `StaticAnalysisFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 147 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:147:13
    |
146 |     pub struct SyntaxFailAssertion {
    |                ------------------- field in this struct
147 |         pub result: String,
    |             ^^^^^^
    |
    = note: `SyntaxFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 142 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:142:13
    |
141 |     pub struct SyntaxSuccessAssertion {
    |                ---------------------- field in this struct
142 |         pub result: String,
    |             ^^^^^^
    |
    = note: `SyntaxSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 75 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:75:28
   |
75 |         StaticAnalysisFail(StaticAnalysisFailAssertion),
   |         ------------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
75 |         StaticAnalysisFail(()),
   |                            ~~

Check warning on line 74 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:74:20
   |
74 |         SyntaxFail(SyntaxFailAssertion),
   |         ---------- ^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
74 |         SyntaxFail(()),
   |                    ~~

Check warning on line 73 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:73:23
   |
73 |         SyntaxSuccess(SyntaxSuccessAssertion),
   |         ------------- ^^^^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
   = note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
73 |         SyntaxSuccess(()),
   |                       ~~

Check warning on line 164 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:164:13
    |
163 |     pub struct EvaluationFailAssertion {
    |                ----------------------- field in this struct
164 |         pub result: String,
    |             ^^^^^^
    |
    = note: `EvaluationFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 157 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:157:13
    |
156 |     pub struct EvaluationSuccessAssertion {
    |                -------------------------- field in this struct
157 |         pub result: String,
    |             ^^^^^^
    |
    = note: `EvaluationSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 152 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:152:13
    |
151 |     pub struct StaticAnalysisFailAssertion {
    |                --------------------------- field in this struct
152 |         pub result: String,
    |             ^^^^^^
    |
    = note: `StaticAnalysisFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 147 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:147:13
    |
146 |     pub struct SyntaxFailAssertion {
    |                ------------------- field in this struct
147 |         pub result: String,
    |             ^^^^^^
    |
    = note: `SyntaxFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 142 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:142:13
    |
141 |     pub struct SyntaxSuccessAssertion {
    |                ---------------------- field in this struct
142 |         pub result: String,
    |             ^^^^^^
    |
    = note: `SyntaxSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 75 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:75:28
   |
75 |         StaticAnalysisFail(StaticAnalysisFailAssertion),
   |         ------------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
75 |         StaticAnalysisFail(()),
   |                            ~~

Check warning on line 74 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:74:20
   |
74 |         SyntaxFail(SyntaxFailAssertion),
   |         ---------- ^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
74 |         SyntaxFail(()),
   |                    ~~

Check warning on line 73 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:73:23
   |
73 |         SyntaxSuccess(SyntaxSuccessAssertion),
   |         ------------- ^^^^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
   = note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
73 |         SyntaxSuccess(()),
   |                       ~~