-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add argument lifetime to BaseTableExpr
's evaluate
#448
base: main
Are you sure you want to change the base?
Conversation
&self, | ||
args: &[Cow<Value>], | ||
args: &'a [Cow<Value>], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also an implicit lifetime on the Cow
as well (the type is actually Cow<'_, Value>
). Can you check this doesn't also need to be named?
As a nit: you may want to throw #![warn(rust_2018_idioms)]
or even #![deny(rust_2018_idioms)]
at the top of your crates' lib.rs to enforce that lifetimes always get written out (unless you feel really strongly about the added verbosity - IMO the benefits of this lint outweigh the downsides). It's easy to forget about implicit lifetimes otherwise.
Conformance comparison report
Number passing in both: 5731 Number failing in both: 612 Number passing in Base (1d5bd99) but now fail: 0 Number failing in Base (1d5bd99) but now pass: 0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix-basetableexpr-errors #448 +/- ##
=========================================================
Coverage 79.25% 79.25%
=========================================================
Files 66 66
Lines 17735 17738 +3
Branches 17735 17738 +3
=========================================================
+ Hits 14055 14058 +3
Misses 3111 3111
Partials 569 569 ☔ View full report in Codecov by Sentry. |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.