Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument lifetime to BaseTableExpr's evaluate #448

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Mar 7, 2024


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr requested a review from am357 March 7, 2024 20:52
&self,
args: &[Cow<Value>],
args: &'a [Cow<Value>],
Copy link

@sadderchris sadderchris Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also an implicit lifetime on the Cow as well (the type is actually Cow<'_, Value>). Can you check this doesn't also need to be named?

As a nit: you may want to throw #![warn(rust_2018_idioms)] or even #![deny(rust_2018_idioms)] at the top of your crates' lib.rs to enforce that lifetimes always get written out (unless you feel really strongly about the added verbosity - IMO the benefits of this lint outweigh the downsides). It's easy to forget about implicit lifetimes otherwise.

Copy link

github-actions bot commented Mar 7, 2024

Conformance comparison report

Base (1d5bd99) 91b7325 +/-
% Passing 90.35% 90.35% 0.00%
✅ Passing 5731 5731 0
❌ Failing 612 612 0
🔶 Ignored 0 0 0
Total Tests 6343 6343 0

Number passing in both: 5731

Number failing in both: 612

Number passing in Base (1d5bd99) but now fail: 0

Number failing in Base (1d5bd99) but now pass: 0

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.25%. Comparing base (d4906a4) to head (6dc377d).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           fix-basetableexpr-errors     #448   +/-   ##
=========================================================
  Coverage                     79.25%   79.25%           
=========================================================
  Files                            66       66           
  Lines                         17735    17738    +3     
  Branches                      17735    17738    +3     
=========================================================
+ Hits                          14055    14058    +3     
  Misses                         3111     3111           
  Partials                        569      569           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from fix-basetableexpr-errors to main March 12, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants