-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Read variable name from Catalog (TypeEnv) during name resolution #427
base: main
Are you sure you want to change the base?
Conversation
During the work for adding a steel thread for PartiQL Typing (Recent PR #389) and after merging #410 to `feat-type-plan-poc` it is realized that we need to refactor the code to remove `DynamicLocalup` `VarExpr` with the assumption that we work based off of Typing and Value Environment from the Catalog. We have a Typing Environment in the Catalog at the moment and we are going to add the Variable Environment as well. In preparation for such task, we need to make the `NameResolver` Catalog aware. In that regard this commit adds the `Catalog` to `NameResolver` Expecting subsequent PR(s) for the name resolving using the Catalog.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 81.87% 81.99% +0.11%
==========================================
Files 62 62
Lines 15883 15899 +16
Branches 15883 15899 +16
==========================================
+ Hits 13004 13036 +32
+ Misses 2362 2342 -20
- Partials 517 521 +4
☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 4589 Number failing in both: 678 Number passing in Base (de1ac1b) but now fail: 1076 Number failing in Base (de1ac1b) but now pass: 0 Click here to see
|
Description of changes:
DO NOT MERGE
TODO:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.