*DO NOT MERGE* Test upgrade to ion v1.0.0-rc #424
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only blocker discovered so far is amazon-ion/ion-rust#624 |
Conformance comparison report
Number passing in both: 5649 Number failing in both: 694 Number passing in Base (d93dfe7) but now fail: 0 Number failing in Base (d93dfe7) but now pass: 0 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
- Coverage 81.70% 81.65% -0.05%
==========================================
Files 62 62
Lines 15235 15183 -52
Branches 15235 15183 -52
==========================================
- Hits 12447 12398 -49
Misses 2285 2285
+ Partials 503 500 -3
☔ View full report in Codecov by Sentry. |
jpschorr
commented
Aug 15, 2023
| encoding: Encoding, | ||
| ) -> IonDecodeResult { | ||
| let reader = ion_rs::element::element_stream_reader::ElementStreamReader::new(contents); | ||
| // Awaiting https://github.com/amazon-ion/ion-rust/issues/624 |
There was a problem hiding this comment.
Blocked on amazon-ion/ion-rust#624
jpschorr
commented
Aug 15, 2023
|
|
||
| // Awaiting https://github.com/amazon-ion/ion-rust/issues/624 |
There was a problem hiding this comment.
Blocked on amazon-ion/ion-rust#624
jpschorr
commented
Aug 15, 2023
| @@ -88,11 +90,15 @@ mod tests { | |||
| let decoded_ion_text = decode_ion_text(ion, encoding).expect("decode text expected"); | |||
| assert_eq!(decoded_ion_text, expected_value); | |||
|
|
|||
| // Awaiting https://github.com/amazon-ion/ion-rust/issues/624 | |||
There was a problem hiding this comment.
Blocked on amazon-ion/ion-rust#624
jpschorr
commented
Aug 15, 2023
| @@ -102,73 +108,67 @@ mod tests { | |||
| assert_eq!(decoded_encoded_text_value, expected_value); | |||
|
|
|||
| // round-trip value through element | |||
| // Awaiting https://github.com/amazon-ion/ion-rust/issues/624 | |||
There was a problem hiding this comment.
Blocked on amazon-ion/ion-rust#624
jpschorr
commented
Aug 15, 2023
| let mut encoded_element_value = | ||
| encode_ion_element(&expected_value, encoding).expect("encode to element"); | ||
| assert_eq!(encoded_element_value.len(), 1); | ||
| */ | ||
|
|
||
| // Awaiting https://github.com/amazon-ion/ion-rust/issues/624 |
There was a problem hiding this comment.
Blocked on amazon-ion/ion-rust#624
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test upgrade to ion-rs v1.0.0-rc to provide release candidate feedback.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.