-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subquery lowering #408
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
==========================================
+ Coverage 81.41% 81.43% +0.02%
==========================================
Files 56 56
Lines 14912 14937 +25
Branches 14912 14937 +25
==========================================
+ Hits 12140 12164 +24
+ Misses 2251 2246 -5
- Partials 521 527 +6
☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 5314 Number failing in both: 980 Number passing in Base (d1bdfb0) but now fail: 4 Number failing in Base (d1bdfb0) but now pass: 24 Click here to see
Click here to see
|
a841aec
to
64b07d4
Compare
// TODO: currently there's no enforcement for unique `OpId` between the outer query | ||
// plan and the subquery plan. To decide if we want the `OpId`s to be unique | ||
// between any subqueries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The subquery plan and outer query plan don't currently enforce unique OpId
s between the two plans. I was going off of how subqueries were modeled in the logical and eval plan as part of #227 and example tests.
I was wondering if we want unique OpId
s between the two plans, which can be helpful for debugging and plan graph visualization.
9366938
to
dc518e8
Compare
dc518e8
to
0773ea0
Compare
Lower subqueries to the logical plan's
SubQueryExpr
node. Targets thefeat-bag-ops
branch since both PRs adjust some query lowering code. Once #400 is merged, this PR will targetmain
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.