-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds non-reserved keywords (POC) #221
base: main
Are you sure you want to change the base?
Conversation
4d3745a
to
0ca11b3
Compare
Codecov ReportBase: 86.28% // Head: 86.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 86.28% 86.72% +0.43%
==========================================
Files 31 31
Lines 5074 5226 +152
==========================================
+ Hits 4378 4532 +154
+ Misses 696 694 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Conformance comparison report
Number passing in both: 349 Number failing in both: 0 Number passing in main but now fail: 0 Number failing in main but now pass: 0 |
0ca11b3
to
489c9f7
Compare
@@ -679,6 +679,55 @@ mod tests { | |||
} | |||
} | |||
|
|||
// PROOF OF CONCEPT: NON-RESERVED KEYWORDS | |||
mod non_reserved { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests all pass without any of the above parser changes, except for with_order
(thought I think the gpml tests would fail when the gpml parsing rules are included).
I'm also not sure that i feel treating order
as an unreserved keyword is a good idea...
Relevant Issues
Description
ACYCLIC
,BOTH
,DOMAIN
,LEADING
,TRAIL
,TRAILING
, andUSER
to match the PR linked aboveORDER
, but this is only becauseORDER
is already used within Rust's grammar as a keyword -- and I wanted to show how existing keywords can be converted to non-reserved keywords.TRAILING
,LEADING
, andBOTH
appropriately.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.