Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Strict mode errors for Comparison ops (<, >, <=, >=) and BETWEEN #417

Open
1 of 3 tasks
jpschorr opened this issue Aug 1, 2023 · 0 comments
Open
1 of 3 tasks

Comments

@jpschorr
Copy link
Contributor

jpschorr commented Aug 1, 2023

Tasks:

These comparison ops (<, >, <=, >=) have different behavior than the equality ops (=, <>) in strict mode. The equality ops should never error in strict mode and never return missing in permissive mode. While the comparison ops should return an error on non-comparable types and return missing in permissive mode.

Perhaps this could be a separate effort/issue to

  • add conformance tests for this behavior
  • fix this implementation

Originally posted by @alancai98 in #413 (comment)

Similar to comparison ops,BETWEEN should fail type check if t1 is not comparable to t2 or t1 is not comparable to t3 (thus resulting in an error in strict mode, missing in permissive mode). Perhaps can track as separate effort to fix and add conformance tests.

Originally posted by @alancai98 in #413 (comment)

@jpschorr jpschorr changed the title Comparison ops (<, >, <=, >=) should follow the spec in strict mode. Implement Strict mode errors for Comparison ops (<, >, <=, >=) and BETWEEN Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant