Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] Rename SPI's type Field to PTypeField #1730

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

alancai98
Copy link
Member

Relevant Issues

  • None

Description

  • Rename SPI's type Field to PTypeField

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 self-assigned this Jan 24, 2025
@alancai98 alancai98 requested a review from johnedquinn January 24, 2025 22:37
Copy link

CROSS-ENGINE-REPORT ❌

BASE (LEGACY-V0.14.8) TARGET (EVAL-60AAA4C) +/-
% Passing 89.67% 94.96% 5.29% ✅
Passing 5287 5618 331 ✅
Failing 609 74 -535 ✅
Ignored 0 224 224 🔶
Total Tests 5896 5916 20 ✅

Testing Details

  • Base Commit: v0.14.8
  • Base Engine: LEGACY
  • Target Commit: 60aaa4c
  • Target Engine: EVAL

Result Details

  • ❌ REGRESSION DETECTED. See Now Failing/Ignored Tests. ❌
  • Passing in both: 2622
  • Failing in both: 18
  • Ignored in both: 0
  • PASSING in BASE but now FAILING in TARGET: 16
  • PASSING in BASE but now IGNORED in TARGET: 102
  • FAILING in BASE but now PASSING in TARGET: 179
  • IGNORED in BASE but now PASSING in TARGET: 0

Now FAILING Tests ❌

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Now IGNORED Tests ❌

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Now Passing Tests

179 test(s) were previously failing in BASE (LEGACY-V0.14.8) but now pass in TARGET (EVAL-60AAA4C). Before merging, confirm they are intended to pass.

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

CROSS-COMMIT-REPORT ❌

BASE (EVAL-F940A3E) TARGET (EVAL-60AAA4C) +/-
% Passing 94.96% 94.96% 0.00% ✅
Passing 5618 5618 0 ✅
Failing 74 74 0 ✅
Ignored 224 224 0 ✅
Total Tests 5916 5916 0 ✅

Testing Details

  • Base Commit: f940a3e
  • Base Engine: EVAL
  • Target Commit: 60aaa4c
  • Target Engine: EVAL

Result Details

  • ❌ REGRESSION DETECTED. See Now Failing/Ignored Tests. ❌
  • Passing in both: 5618
  • Failing in both: 74
  • Ignored in both: 224
  • PASSING in BASE but now FAILING in TARGET: 8
  • PASSING in BASE but now IGNORED in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 8
  • IGNORED in BASE but now PASSING in TARGET: 0

Now FAILING Tests ❌

The following 8 test(s) were previously PASSING in BASE but are now FAILING in TARGET:

Click here to see
  1. structs should be ordered by data types (DESC) (nulls first as default for desc), compileOption: PERMISSIVE
  2. structs should be ordered by data types (DESC) (nulls first as default for desc), compileOption: STRICT
  3. group by with where, compileOption: PERMISSIVE
  4. group by with where, compileOption: STRICT
  5. group by with group as and where, compileOption: PERMISSIVE
  6. group by with group as and where, compileOption: STRICT
  7. repeated field on struct is ambiguous{identifier:"REPEATED",cn:9,bn:"REPEATED"}, compileOption: STRICT
  8. repeated field on struct is ambiguous{identifier:" "repeated" ",cn:10,bn:"repeated"}, compileOption: STRICT

Now Passing Tests

The following 8 test(s) were previously FAILING in BASE but are now PASSING in TARGET. Before merging, confirm they are intended to pass:

Click here to see
  1. repeated field on struct is ambiguous{identifier:"REPEATED",cn:9,bn:"REPEATED"}, compileOption: STRICT
  2. repeated field on struct is ambiguous{identifier:" "repeated" ",cn:10,bn:"repeated"}, compileOption: STRICT
  3. structs should be ordered by data types (DESC) (nulls first as default for desc), compileOption: PERMISSIVE
  4. structs should be ordered by data types (DESC) (nulls first as default for desc), compileOption: STRICT
  5. group by with where, compileOption: PERMISSIVE
  6. group by with where, compileOption: STRICT
  7. group by with group as and where, compileOption: PERMISSIVE
  8. group by with group as and where, compileOption: STRICT

@alancai98 alancai98 merged commit 97741fa into main Jan 24, 2025
14 checks passed
@alancai98 alancai98 deleted the rename-type-field branch January 24, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants