Adds Fn, FnProvider, Agg, and AggProvider APIs #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnedquinn
force-pushed
the
main-fn-agg-apis
branch
2 times, most recently
from
7ad1acc to
609f1ea
Compare
alancai98
reviewed
Jan 21, 2025
partiql-spi/src/main/java/org/partiql/spi/function/FnProvider.java
Outdated
Show resolved
Hide resolved
partiql-spi/src/main/java/org/partiql/spi/function/FnProvider.java
Outdated
Show resolved
Hide resolved
partiql-spi/src/main/java/org/partiql/spi/function/AggProvider.java
Outdated
Show resolved
Hide resolved
partiql-spi/src/main/java/org/partiql/spi/function/FnProvider.java
Outdated
Show resolved
Hide resolved
partiql-spi/src/main/kotlin/org/partiql/spi/function/Aggregation.kt
Outdated
Show resolved
Hide resolved
partiql-spi/src/main/kotlin/org/partiql/spi/function/Function.kt
Outdated
Show resolved
Hide resolved
partiql-spi/src/main/kotlin/org/partiql/spi/function/Builtins.kt
Outdated
Show resolved
Hide resolved
alancai98
reviewed
Jan 21, 2025
partiql-spi/src/main/java/org/partiql/spi/function/RoutineProviderSignature.java
Outdated
Show resolved
Hide resolved
johnedquinn
force-pushed
the
main-fn-agg-apis
branch
from
609f1ea to
8bd06ff
Compare
alancai98
reviewed
Jan 22, 2025
partiql-spi/src/main/kotlin/org/partiql/spi/function/Aggregation.kt
Outdated
Show resolved
Hide resolved
partiql-spi/src/main/kotlin/org/partiql/spi/function/Aggregation.kt
Outdated
Show resolved
Hide resolved
johnedquinn
force-pushed
the
main-fn-agg-apis
branch
from
0ab406b to
dfb15e0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1722 +/- ##
=========================================
Coverage 80.03% 80.03%
Complexity 47 47
=========================================
Files 19 19
Lines 506 506
Branches 23 23
=========================================
Hits 405 405
Misses 88 88
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alancai98
reviewed
Jan 22, 2025
There was a problem hiding this comment.
latest changes lgtm. seems like there's a slight conformance regression with this PR -- https://github.com/partiql/partiql-lang-kotlin/actions/runs/12917164270. could we verify we're not introducing any behavior changes?
Adds a RoutineSignature and RoutineProviderSignature Adds a RoutineProviderParam Adds scalar and aggregate function builders Updates existing function implementations to use new APIs
Removes the RoutineProviderParameter in favor of PType Updates Javadocs Renames internal SUBSTRING name
johnedquinn
force-pushed
the
main-fn-agg-apis
branch
from
239cdb4 to
4f089b2
Compare
johnedquinn
force-pushed
the
main-fn-agg-apis
branch
from
fba3757 to
fb9b637
Compare
alancai98
reviewed
Jan 24, 2025
Comment on lines
316
to
319
| p.type.code() == a.code() -> continue | ||
| a.code() == PType.DYNAMIC -> mapping[i] = Ref.Cast(a.toCType(), p.type.toCType(), Ref.Cast.Safety.COERCION, true) | ||
| p.type.code() == PType.DYNAMIC -> continue | ||
| else -> mapping[i] = coercion(a, p.type) ?: return null |
There was a problem hiding this comment.
could we add a small comment/description of what these additional branches are for?
alancai98
previously approved these changes
Jan 24, 2025
alancai98
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewing
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.