Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] Fix ABS integer overflow; add parsing of TINYINT #1716

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alancai98
Copy link
Member

Relevant Issues

Description

  • Adds parsing of TINYINT
  • Fix ABS integer overflow
  • Enables some previous TINYINT overflow tests

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 requested a review from johnedquinn January 15, 2025 00:54
@alancai98 alancai98 self-assigned this Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

CROSS-ENGINE-REPORT ❌

BASE (LEGACY-V0.14.8) TARGET (EVAL-B6154BB) +/-
% Passing 89.67% 93.20% 3.53% ✅
Passing 5287 5495 208 ✅
Failing 609 115 -494 ✅
Ignored 0 286 286 🔶
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: v0.14.8
  • Base Engine: LEGACY
  • Target Commit: b6154bb
  • Target Engine: EVAL

Result Details

  • ❌ REGRESSION DETECTED. See Now Failing/Ignored Tests. ❌
  • Passing in both: 2614
  • Failing in both: 32
  • Ignored in both: 0
  • PASSING in BASE but now FAILING in TARGET: 26
  • PASSING in BASE but now IGNORED in TARGET: 114
  • FAILING in BASE but now PASSING in TARGET: 165
  • IGNORED in BASE but now PASSING in TARGET: 0

Now FAILING Tests ❌

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Now IGNORED Tests ❌

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Now Passing Tests

165 test(s) were previously failing in BASE (LEGACY-V0.14.8) but now pass in TARGET (EVAL-B6154BB). Before merging, confirm they are intended to pass.

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

CROSS-COMMIT-REPORT ✅

BASE (EVAL-FC208AA) TARGET (EVAL-B6154BB) +/-
% Passing 93.20% 93.20% 0.00% ✅
Passing 5495 5495 0 ✅
Failing 115 115 0 ✅
Ignored 286 286 0 ✅
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: fc208aa
  • Base Engine: EVAL
  • Target Commit: b6154bb
  • Target Engine: EVAL

Result Details

  • Passing in both: 5495
  • Failing in both: 115
  • Ignored in both: 286
  • PASSING in BASE but now FAILING in TARGET: 0
  • PASSING in BASE but now IGNORED in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 0
  • IGNORED in BASE but now PASSING in TARGET: 0

Copy link
Member

@johnedquinn johnedquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants