[v1] Change integer types to error on overflow; give explicit data exception on div/mod by 0 #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CROSS-ENGINE-REPORT ❌
Testing Details
Result Details
Now FAILING Tests ❌The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. Now IGNORED Tests ❌The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. Now Passing Tests165 test(s) were previously failing in BASE (LEGACY-V0.14.8) but now pass in TARGET (EVAL-68547A4). Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. CROSS-COMMIT-REPORT ✅
Testing DetailsResult Details
|
alancai98
force-pushed
the
int-overflow
branch
2 times, most recently
from
8d67e7b to
afc865a
Compare
…ception on div/mod by 0
alancai98
force-pushed
the
int-overflow
branch
from
afc865a to
34f1aa3
Compare
johnedquinn
reviewed
Jan 14, 2025
| val arg0 = args[0].byte | ||
| val arg1 = args[1].byte | ||
| if (arg1 == 0.toByte()) { | ||
| throw DataException("Division by zero for TINYINT: $arg0 % $arg1") |
There was a problem hiding this comment.
Nice 👍 . SQL:1999 Section 6.17.
johnedquinn
reviewed
Jan 14, 2025
| val arg1 = args[1].byte | ||
| val result = arg0 + arg1 | ||
| if (result.byteOverflows()) { | ||
| throw DataException("Numeric value out of range for TINYINT: $arg0 + $arg1") |
There was a problem hiding this comment.
Suggested change
| throw DataException("Numeric value out of range for TINYINT: $arg0 + $arg1") | |
| throw DataException("Resulting value out of range for TINYINT: $arg0 + $arg1") |
Non-blocking, but the use of "numeric" might be confusing due to there being a numeric data type.
johnedquinn
approved these changes
Jan 14, 2025
johnedquinn
reviewed
Jan 14, 2025
| @@ -21,7 +21,7 @@ internal object FnDivide : DiadicArithmeticOperator("divide") { | |||
| if (arg1 == 0.toByte()) { | |||
| throw DataException("Division by zero for TINYINT: $arg0 / $arg1") | |||
| } else if (arg0 == Byte.MIN_VALUE && arg1.toInt() == -1) { | |||
| throw DataException("Overflow for TINYINT: $arg0 / $arg1") | |||
| throw DataException("Resulting value out of range for: $arg0 / $arg1") | |||
There was a problem hiding this comment.
For the following 3, you removed the type name.
There was a problem hiding this comment.
Ah my bad. I will fix in the target branch.
alancai98
added a commit
that referenced
this pull request
Jan 15, 2025
…or on overflow * [v1] Re-enable randomized tests * [v1] Change integer types to error on overflow; give explicit data exception on div/mod by 0 (#1715)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Description
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.