Initializes PartiQL Value classes #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5380 Number failing in both: 438 Number passing in Base (5b8a60f) but now fail: 0 Number failing in Base (5b8a60f) but now pass: 0 |
johnedquinn
reviewed
May 22, 2023
partiql-types/src/main/kotlin/org/partiql/value/PartiQLValue.kt
Outdated
Show resolved
Hide resolved
partiql-types/src/main/kotlin/org/partiql/value/PartiQLValue.kt
Outdated
Show resolved
Hide resolved
partiql-types/src/main/kotlin/org/partiql/value/PartiQLValue.kt
Outdated
Show resolved
Hide resolved
partiql-types/src/main/kotlin/org/partiql/value/PartiQLValue.kt
Outdated
Show resolved
Hide resolved
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1091 +/- ##
=========================================
Coverage 73.19% 73.19%
Complexity 2376 2376
=========================================
Files 237 237
Lines 17261 17261
Branches 3133 3133
=========================================
Hits 12635 12635
Misses 3653 3653
Partials 973 973
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
11 tasks
RCHowell
changed the title
RCHowell
commented
Jun 16, 2023
partiql-types/src/main/kotlin/org/partiql/value/PartiQLValue.kt
Outdated
Show resolved
Hide resolved
partiql-types/src/main/kotlin/org/partiql/value/PartiQLValue.kt
Outdated
Show resolved
Hide resolved
yliuuuu
requested changes
Jun 16, 2023
partiql-types/src/main/kotlin/org/partiql/value/PartiQLValueReader.kt
Outdated
Show resolved
Hide resolved
partiql-types/src/main/kotlin/org/partiql/value/PartiQLValue.kt
Outdated
Show resolved
Hide resolved
johnedquinn
requested changes
Jun 20, 2023
There was a problem hiding this comment.
Only small nits to be fixed and perhaps the inclusion of an experimental annotation since these APIs will likely be broken in future releases. I'll leave the discussion regarding streams up to both you and @yliuuuu .
partiql-types/src/main/kotlin/org/partiql/value/PartiQLValueReader.kt
Outdated
Show resolved
Hide resolved
yliuuuu
approved these changes
Jun 21, 2023
johnedquinn
approved these changes
Jun 21, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an iteration of ExprValue (split from evaluator) informed by IonElement. Notably supporting annotations #1093 and defining Reader/Writer interfaces
Other Information
Updated Unreleased Section in CHANGELOG: [YES/NO]
NO
Any backward-incompatible changes? [YES/NO]
NO
Any new external dependencies? [YES/NO]
org.jetbrains.kotlinx:kotlinx-collections-immutableLicense Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.